[Webkit-unassigned] [Bug 63897] [CSSRegions] Parse content-order property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63897


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99636|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Dave Hyatt <hyatt at apple.com>  2011-07-06 14:41:42 PST ---
(From update of attachment 99636)
View in context: https://bugs.webkit.org/attachment.cgi?id=99636&action=review

Minor nits.

> LayoutTests/ChangeLog:13
> +        ():
> +        (testComputedStyle):
> +        (testNotInherited):

Not sure why the changelog did this, but you can just remove these lines.

> Source/WebCore/css/CSSStyleSelector.cpp:4882
> +        if (primitiveValue)

Confused why HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE can't be used here.

> Source/WebCore/rendering/style/RenderStyle.h:1099
> +    void setRegionIndex(int i) { SET_VAR(rareNonInheritedData, m_regionIndex, i); }

Change "i" to "index" please. We don't like single-letter variable names for parameters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.