[Webkit-unassigned] [Bug 61877] TestFailures page doesn't show testers that use new-run-webkit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 6 13:05:28 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61877





--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-06 13:05:28 PST ---
(From update of attachment 99865)
View in context: https://bugs.webkit.org/attachment.cgi?id=99865&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js:74
>> +            result.tests[test.name] = { failureType: convertNRWTResultString(test.actual) };
> 
> A couple things:
> 
> 1) You'll need to split test.actual on " " because there can be multiple actual results for a given test in a given run.
> 2) You'll need to compare against test.expected otherwise you'll get a bunch of bogus failure reports about tests that we expect to fail.

1) You can see in convertNRWTResultString that I explicitly handle the " " case and just call the test "flaky".
2) We're loading unexpected_results.json, so I don't think we'll see any tests where we expect failure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list