[Webkit-unassigned] [Bug 61528] Fix the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61528





--- Comment #6 from Matthew Delaney <mdelaney at apple.com>  2011-07-06 10:43:01 PST ---
(From update of attachment 95173)
View in context: https://bugs.webkit.org/attachment.cgi?id=95173&action=review

Overall, looks good.

> LayoutTests/ChangeLog:5
> +        Removing "canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface" test from skip lists for bug https://bugs.webkit.org/show_bug.cgi?id=61528

How does this change affect the tests 2d.text.draw.fill.maxWidth.{small,larger,zero}? I just looked at them briefly and they have written in them that they can't be verified automatically, though I'm not sure why. I imagine versions that used a font like Ahem with a maxWidth to try to cover (or not cover) the canvas and then checks the pixel values after. Don't change the philip tests, but you could instead add some tests to fast/canvas that test things such as: a negative/zero/very large/very small 'maxWidth'.

> LayoutTests/ChangeLog:7
> +        * platform/chromium/test_expectations.txt:

Unless it was removed recently, it appears there's also an expected results in platform/chromium of passing that could also be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.