[Webkit-unassigned] [Bug 61573] Update LayoutTests/media/broken-video to test for correct error codes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 6 08:13:39 PDT 2011


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
  Attachment #95064|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2011-07-06 08:13:38 PST ---
(From update of attachment 95064)
View in context: https://bugs.webkit.org/attachment.cgi?id=95064&action=review

r=me with the changes suggested.

> LayoutTests/media/broken-video.html:2
> +<p>Test that QuickTime file with broken headers and content generates a SRC_NOT_SUPPORTED error.<p>

This comment is incorrect as the test will not open a QuickTime movie, the two files that can be opened are garbage.mp4 and garbage.ogv. You also added a check for networkState so you may as well mention that as well. Something like "Tests that an invalid video file generates a MEDIA_ERR_SRC_NOT_SUPPORTED error and sets networkState to NETWORK_NO_SOURCE" perhaps?

> LayoutTests/media/broken-video.html:11
> +        testExpected("video.error.code", "4");
> +        testExpected("video.networkState", "3");

I would prefer to have the named constants used here:

    testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);
    testExpected("video.networkState", HTMLMediaElement.NETWORK_NO_SOURCE);

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list