[Webkit-unassigned] [Bug 54476] HTMLInputElement has two similarly named methods: "checked" and "isChecked"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54476


SravanKumar <sravan.ken at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99805|                            |review?
               Flag|                            |




--- Comment #4 from SravanKumar <sravan.ken at gmail.com>  2011-07-06 03:04:06 PST ---
Created an attachment (id=99805)
 --> (https://bugs.webkit.org/attachment.cgi?id=99805&action=review)
Patch v1

HTMLInputElement::isChecked() is called only for Radio button & Checkboxes. When a radiobutton or checkbox is set, checked() returns TRUE & m_inputType->isCheckable() also returns TRUE. Therefore to find out whether a radio button or checkbox is set, checking checked() is sufficient, no need to check for m_inputType->isCheckable().

Therefore, we have replaced all the instances of isChecked() with checked().

Also, we have tested the radio/checkbox related test cases in LayoutTest/fast/forms, so no need to add additional test cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.