[Webkit-unassigned] [Bug 27570] [CSS3 Backgrounds and Borders] Add support for the "space" value for background-repeat

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 6 01:27:08 PDT 2011


--- Comment #10 from MORITA Hajime <morrita at google.com>  2011-07-06 01:27:07 PST ---
(From update of attachment 99701)
View in context: https://bugs.webkit.org/attachment.cgi?id=99701&action=review

Hi Alexandru,
Thank you doing this. I try to give some feedback.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:768
>          LayoutSize tileSize;

How about start with bringing these parameters together into a class, namely BackgroundImageGeometry, in a separate patch?
It would make this change clearer and smaller.

> Source/WebCore/rendering/RenderBoxModelObject.h:137
> +    bool calculateBackgroundImageGeometry(const FillLayer*, const IntRect& paintRect, IntRect& destRect, IntPoint& phase, IntSize& tileSize, IntSize& padding);

How about to define overloaded version which doesn't have |padding| parameter.
It looks many caller site just passes dummy value, which makes code complicated and
makes this change larger than necessary.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list