[Webkit-unassigned] [Bug 63897] [CSSRegions] Parse content-order property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63897





--- Comment #2 from Eric Seidel <eric at webkit.org>  2011-07-05 18:12:53 PST ---
(From update of attachment 99636)
View in context: https://bugs.webkit.org/attachment.cgi?id=99636&action=review

Seems reasonable, but I'd like tony/luke to comment.

> LayoutTests/fast/regions/webkit-content-order-parsing-expected.txt:12
> +PASS testCSSText("-webkit-content-order: 1") is "1"
> +PASS testCSSText("-webkit-content-order: 0") is "0"
> +PASS testCSSText("-webkit-content-order: -1") is "-1"
> +PASS testCSSText("-webkit-content-order: 12.5") is ""

Do we need to test boundaries?  Like INT_MAX?

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1663
> +            return primitiveValueCache->createValue(style->regionIndex(), CSSPrimitiveValue::CSS_NUMBER);

I thought Tony Chang recently added some wrappers for accessing the primativeValueCache?

> Source/WebCore/css/CSSStyleSelector.cpp:4883
> +    case CSSPropertyWebkitContentOrder:
> +        if (isInitial) {
> +            HANDLE_INITIAL_COND(CSSPropertyWebkitContentOrder, RegionIndex);
> +            return;
> +        }
> +        if (isInherit) {
> +            m_style->setRegionIndex(RenderStyle::initialRegionIndex());
> +            return;
> +        }
> +        if (primitiveValue)
> +            m_style->setRegionIndex(primitiveValue->getIntValue());

Luke should comment if this is the correct modern syntax.

> Source/WebCore/rendering/style/RenderStyle.cpp:348
> +        if (rareNonInheritedData->m_regionIndex != other->rareNonInheritedData->m_regionIndex)
> +            return StyleDifferenceLayout;

You might have put this in the if above.  Not sure it really matters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.