[Webkit-unassigned] [Bug 63313] The return value of SharedBuffer::createWithContentsOfFile must have valid m_size.

Tue Jul 5 18:06:10 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=63313

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98460|commit-queue+               |
               Flag|                            |

--- Comment #6 from Eric Seidel <eric at webkit.org>  2011-07-05 18:06:10 PST ---
(From update of attachment 98460)
Clearing cq+.

It seems to me it would be better for this code to read into a Vector and then create the SharedBuffer from the Vector.  SharedBuffer doesn't seem to be designed to be read into directly, it's meant to wrap other data storage mechanisms.  Since this POSIX implementation doesn't have any "native" data storage, seems we should use Vector.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.