[Webkit-unassigned] [Bug 21591] prepare-ChangeLog should know how to find functions in Perl files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21591





--- Comment #7 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-05 15:15:22 PST ---
(From update of attachment 99751)
View in context: https://bugs.webkit.org/attachment.cgi?id=99751&action=review

>> Tools/Scripts/prepare-ChangeLog:1232
>> +                warn "nested functions found at top-level at $fileName:$.\n";
> 
> FYI, it is possible to nest subroutines in Perl.  You can define a subroutine and assign it to a variable, too.
> 
> I guess you can change $currentFunction to @currentFunction later.

Yes, I just decided to punt on nested subroutines in this patch. Note that we'll only complain if the nested function isn't indented, like this:

sub outerFunction
{

sub innerFunction
{
}

}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.