[Webkit-unassigned] [Bug 56401] hover then un-hover makes state change

Tue Jul 5 03:19:52 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56401

--- Comment #7 from MORITA Hajime <morrita at google.com>  2011-07-05 03:19:52 PST ---
(From update of attachment 99686)
View in context: https://bugs.webkit.org/attachment.cgi?id=99686&action=review

> LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt:1
> +CONSOLE MESSAGE: line 0: 

You need to eliminate all error messages.

> LayoutTests/fast/dynamic/hover-before-position-after-style-change.html:1
> +<html>

Could you add doctype?

> LayoutTests/fast/dynamic/hover-before-position-after-style-change.html:10
> +            Hover the mouse over the "Inline" text. The test passes if you see a "PASS" below.

"PASS" is a kind of convention So you don't need to mention it explicitly.
Instead of that, manual testing instruction would be preferable here.

> LayoutTests/fast/dynamic/hover-before-position-after-style-change.html:20
> +            function getElementTop(elementId) {

"{" should be placed on the next line.
The coding convention is almost same as one of c++.
(Unfortunately, check-webkit-style doesn't check JavaScript inside HTML...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.