[Webkit-unassigned] [Bug 63911] REGRESSION (r89774): svg/W3C-SVG-1.1/animate-elem-82-t.svg hits assertion failure.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63911





--- Comment #4 from Young Han Lee <joybro at company100.net>  2011-07-04 19:01:46 PST ---
(In reply to comment #3)
> (From update of attachment 99648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99648&action=review
> 
> This is a regression, so we need a regression test. Can you add a test to svg/animation please? I also have a question to your fix. r- because of the missing test.

I'm not sure what kind of test could be added in this case because this regression has no symptoms, looks like working correctly, apart from assertion failures, and the assertion failures are not even occurred if the testcase has runAnimationTests() like our testcases in svg/animations.

> 
> > Source/WebCore/svg/SVGAnimationElement.cpp:494
> > +    if (percent == 1) {
> > +        from = m_values[valuesCount - 1];
> > +        to = m_values[valuesCount - 1];
> > +        effectivePercent = 1;
> > +        return;
> > +    }
> 
> I just wonder. Here we return always effectivePercent = 1 if percent is 1,...
> 
> > Source/WebCore/svg/SVGAnimationElement.cpp:520
> >      if (calcMode == CalcModeDiscrete) {
> >          if (!keyTimesCount) 
> > -            index = percent == 1 ? valuesCount - 1 : static_cast<unsigned>(percent * valuesCount);
> > +            index = static_cast<unsigned>(percent * valuesCount);
> >          from = m_values[index];
> >          to = m_values[index];
> >          effectivePercent = 0;
> 
> here we return effectivePercent = 0 for discrete animations. Sure that this doesn't cause new problems?

Yes, the effectivePercent is meaningful only if the 'from' and 'to' have different values. I checked that this doesn't affect the calculation result.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.