[Webkit-unassigned] [Bug 62345] [V8][Chromium] Use per-isolate embedder data instead of statics for caches in bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62345





--- Comment #23 from Dmitry Lomov <dslomov at google.com>  2011-07-04 14:34:26 PST ---
Hans, thanks for tracking this down - I guess it wasn't easy...

(In reply to comment #22)
> Please file a new bug rather than posting to this closed bug.
> 
> The problem is that OwnHandle is responsible for calling New and Disposed in a balanced way.  Because this code calls New, that New is never balanced with a Dispose, which leads to the leak.

I do not think you are right: I am not sure what is the problem with the code yet, but OwnHandle only calls New and Dispose on Persistent, and this code calls New on Context. I feel this usage should be OK, but there might be a subtle reason for it not to - maybe I somehow misunderstand OwnHandle?

Anyway, it looks like OwnHandle leads to too much subtlety in this code, and direct use of Persistent (as in  https://bug-62345-attachments.webkit.org/attachment.cgi?id=96803 or Hans' patch) is much easier to reason about.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.