[Webkit-unassigned] [Bug 63851] Crash when loading a document in an editable WebView that has a subframe with an unstyled body

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 15:53:40 PDT 2011


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #99528|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2011-07-01 15:53:40 PST ---
(From update of attachment 99528)
View in context: https://bugs.webkit.org/attachment.cgi?id=99528&action=review

> Source/WebCore/editing/Editor.cpp:2893
>      CSSStyleDeclaration* style = element->style();
>      ASSERT(style);
> +    if (!style)
> +        return;

This change seems OK, but I’m not sure why it’s needed.

> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:223
> +    if (([webView mainFrame] == webFrame) && [webView isEditable])

No need for the parentheses here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list