[Webkit-unassigned] [Bug 63709] Disabled input type=search still allows clicking [x] to clear contents

Fri Jul 1 03:11:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=63709

Kentaro Hara <haraken at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99295|1                           |0
        is obsolete|                            |

--- Comment #6 from Kentaro Hara <haraken at google.com>  2011-07-01 03:11:46 PST ---
(From update of attachment 99295)
View in context: https://bugs.webkit.org/attachment.cgi?id=99295&action=review

>> LayoutTests/fast/forms/search-cancel-button-mouseup.html:2
>>  <html>
> 
> This file is for 'cancel-button-mouseup'. So merging a test case of this bug is not suitable.
> We have disabled-search-input.html.  It's a better place to add the test case.

Done. Reverted search-cancel-button-mouseup.html to the original.

>> LayoutTests/fast/forms/search-cancel-button-mouseup.html:13
>> +<input id="search5" type="search" value="value5" disabled="disabled"><br />
> 
> You fixes 'readonly' too.  So you should make test cases for 'readonly' too.

Added the test cases.

>> LayoutTests/fast/forms/search-cancel-button-mouseup.html:22
>> +    var input = document.getElementById("search0");
> 
> nit: You can use getElementsByTagName('input') and index-access. Also, resources/common.js has $().

I removed multiple 'input's and instead used one 'input' in the latest patch.

>> LayoutTests/fast/forms/search-cancel-button-mouseup.html:43
>> +    eventSender.mouseUp();
> 
> You had better have click(x, y) function.

Done.

>> Source/WebCore/ChangeLog:5
>> +        Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute is set.
> 
> Please mention 'readonly' too.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.