[Webkit-unassigned] [Bug 53004] Introduces DriverInput and DriverOutput classes and single_test_runner module.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53004





--- Comment #5 from Hayato Ito <hayato at chromium.org>  2011-01-31 21:19:02 PST ---
Is there any WebKit reviewer to take a look at this patch and set r+? I'll appreciate if you review this.


(In reply to comment #4)
> Hi Eric, Dirk, thank you for the reviews.
> 
> (In reply to comment #2)
> > (From update of attachment 79916 [details] [details])
> > Why would we want to move DriverOutput out of its own file and into a shared file?
> >
> 
> As Dirk mentioned, I'd like to move Driver* classes out of port/base.py as well as Driver class itself in another patch. So in this patch, please forgive me that DriverInput/Out classes are put on port/base.py. Driver and DirverInput/Output classes are tightly related.
> 
> > This change is still qutie large.  The rename could be done first and easily rubber-stamped.
> 
> 
> I could have separated this patch into two patches for easy reviewing, but I couldn't help but move _process_output() method to a separated module when I tried to modify  _process_output() function in dump_render_thread.py so that that uses DriverInput/Output classes :)
> 
> > I guess you're moving single-test-running logic from dump_render_tree_thread onto its own class?  That sounds like a very good idea.
> > 
> > Are you just moving code, or causing functional changes as well?
> 
> single_test_runner.py contains only moved code from dump_render_tree.py as of now. There is no functional change. That's just moving stuff around.
> 
> It seems that there is no easy way to know 'diff' in bugzilla if we move the code and modify it a little. Sorry for the inconvenience.
> 
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 79916 [details] [details] [details])
> > > Why would we want to move DriverOutput out of its own file and into a shared file?
> > >
> > 
> > Read the comments in the other bug ... the motivation is that TestInput and TestOutput are really pretty closely tied to the Driver class, and so it makes sense to rename them and move them to be next to the other class. I suggested that we actually move all of the Driver* classes out of base.py and into a driver.py (or some such file), but I could understand it if Ito-san didn't want to do that as part of this patch.
> 
> Thank you for the comment, Dirk. I think you can tell what I am thinking successfully :) 
> 
> > 
> > This change looks like it's just moving stuff around, and it looks good to me (though I can't R+ it).
> 
> There should be no functional change in this patch. Just a first attempt to clean up and keeping things simple. I'll continue to create patches, which are separated from https://bugs.webkit.org/show_bug.cgi?id=51091
> 
> I'll separe this patch into two patches if that is needed.
> If you are confortable as is, r+ is welcome :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.