[Webkit-unassigned] [Bug 52311] [chromium] Add command-line flag to enable composite to offscreen texture.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52311





--- Comment #48 from Vangelis Kokkevis <vangelis at chromium.org>  2011-01-31 17:46:27 PST ---
(In reply to comment #47)
> (In reply to comment #45)
> > Are you still seeing diffs, even after:
> >
> > http://trac.webkit.org/changeset/76299
> 
> Yes.
> 
> The changeset you mention was helpful in resolving the only pixel difference I was encountering on Mac, but it does not resolve the pixel differences I'm seeing on Linux.
> 
> (In reply to comment #46)
> > (From update of attachment 79426 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=79426&action=review
> > 
> > > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:645
> > > +        m_context->colorMask(true, true, true, true);
> > 
> > Now that the color mask is set to (t,t,t,t) in the LayerRendererChromium ln 266, you should avoid resetting it here.  I wonder if this will clear the problems you're seeing..
> 
> No, it doesn't help. I tried all 4 combinations of including/removing each of the two calls to colorMask() and the results are the same in each case.

They colorMask calls should be removed anyway as they're not consistent anymore with the state that the compositor uses (compositor expects color to be unmasked most of the time).  

My only other guess for the differences you're seeing is that something is off by a fraction of a pixel and you're seeing slight stretching. Our textures are by default using LINEAR filtering.  You could try setting the TEXTURE_MIN_FILTER, TEXTURE_MAG_FILTER to NEAREST .  You could do that in RenderSurface::prepareContentsTexture, after the call to reserve() you can bind the texture and set the filter modes.

The reason I'd like to get to the bottom of this is that it would be nice to know that you can use the off-screen path as your primary render path which means that you'd need the layout tests to work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.