[Webkit-unassigned] [Bug 25757] VisibleSelection cannot represent all selection types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25757





--- Comment #13 from Benjamin (Ben) Kalman <kalman at chromium.org>  2011-01-31 17:39:33 PST ---
(In reply to comment #12)
> > Yep.  When I said that the start of a selection always has DOWNSTREAM and the start UPSTREAM I was referring to the visibleStart and visibleEnd methods which return DOWNSTREAM vs UPSTREAM respectively.  Perhaps this is what should be changed.
> 
> This is an attempt to ensure we use the "smallest" possible selection that represents the underlying positions for editing. If we change visibleStart to always return the upstream VisiblePosition, we'll be switching this to being greedy, which will cause unintended consequences in other editing code.

Oh, I wasn't suggesting this.  More like what you said below, or replacing setAffinity with setStartAffinity and getEndAffinity.  From what I (eclipse) can tell, the only place it's called is SelectionController:modify anyway.

> 
> I believe VisibleSelection needs to track multiple affinities that it derives based on the VisiblePositions passed in, but I'm not sure without looking more if we need 2 or 4 to cover all cases on all platforms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.