[Webkit-unassigned] [Bug 25757] VisibleSelection cannot represent all selection types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25757





--- Comment #11 from Benjamin (Ben) Kalman <kalman at chromium.org>  2011-01-31 17:19:59 PST ---
(In reply to comment #10)
> Ahh, more bugs from my early days. Apologies...
> 
> The source of this bug is VisibleSelection. VisibleSelection, in an effort to avoid the overhead and relayout issues of VisiblePositions, uses a set of Positions and one affinity. The single affinity is only used for Caret selections, which does not cover all cases, this one included.

This sort of thing is what I meant by "what does the affinity of a whole selection really mean".

> 
> VisibleSelection needs *at least* two affinities, one each for start and end, so it can keep track of a selection that covers both a downstream and upstream Position like the one we're trying to make here.

Yep.  When I said that the start of a selection always has DOWNSTREAM and the start UPSTREAM I was referring to the visibleStart and visibleEnd methods which return DOWNSTREAM vs UPSTREAM respectively.  Perhaps this is what should be changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.