[Webkit-unassigned] [Bug 53462] New: Using Control-C to cancel webkit-patch or other python tools causes unpleasant traceback console spew

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53462

           Summary: Using Control-C to cancel webkit-patch or other python
                    tools causes unpleasant traceback console spew
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: darin at apple.com
                CC: eric at webkit.org


For example, I hit Control-C when webkit-patch was asking me about a diff

Was that diff correct? [Y/n]: Traceback (most recent call last):
  File "/Users/darin/Safari/OpenSource/Tools/Scripts/webkit-patch", line 70, in <module>
    main()
  File "/Users/darin/Safari/OpenSource/Tools/Scripts/webkit-patch", line 65, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py", line 73, in run
    diff_correct = self._tool.user.confirm("Was that diff correct?")
  File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 128, in confirm
    response = raw_input("%s [%s]: " % (message, choice))
KeyboardInterrupt

Yuck!

Who else should I cc on this bug?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.