[Webkit-unassigned] [Bug 50036] update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment

Mon Jan 31 14:00:27 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50036

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77891|review?                     |review+
               Flag|                            |

--- Comment #6 from Daniel Bates <dbates at webkit.org>  2011-01-31 14:00:27 PST ---
(From update of attachment 77891)
View in context: https://bugs.webkit.org/attachment.cgi?id=77891&action=review

Looks good to me.

> Tools/Scripts/run-webkit-httpd:5
> +# Copyright (C) Research In Motion Limited 2010. All rights reserved.

Nit: 2010 should be 2011.

> Tools/Scripts/webkitperl/httpd.pm:4
> +# Copyright (C) Research In Motion Limited 2010. All rights reserved.

Ditto.

> Tools/Scripts/webkitperl/httpd.pm:82
> +        $httpdPath = "/c/program\ files/apache\ software\ foundation/apache2.2/bin/httpd.exe";

It would be nicer if we could write this in such a way that we didn't need to escape the space characters in the path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.