[Webkit-unassigned] [Bug 52609] Add navigator.registerProtocolHandler behind a flag.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 13:34:35 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52609





--- Comment #33 from Eric Seidel <eric at webkit.org>  2011-01-31 13:34:34 PST ---
(In reply to comment #32)
> (In reply to comment #31)
> > They don't need to be enforced at all cost, but where possible it makes sense to me to enforce them as we would with any other code. Using a shared style in layout tests has all the same benefits it does for non-test code. 
> 
> (In reply to comment #30)
> > Parsing tests belong as parsing tests.  Not as an excuse for code style diversity.
> 
> Interesting. I explicitly have avoided enforcing style on layout tests due to this. I should probably change that.

I don't really know what our javascript/layout-test style looks like.  Seems we should define one if we want to enforce it. :)  Things like { on the same line as an if, and 4-space indent, and descriptive variable names seem common throughout all languages that WebKit uses.  But AFAIK we don't have any explicit style guides for layout tests/html/js yet (but probably should)!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list