[Webkit-unassigned] [Bug 53420] [Qt] PluginViewQt.cpp not compiling with ENABLE_NETSCAPE_PLUGIN_API=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53420


Robert Hogan <robert at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robert at webkit.org




--- Comment #3 from Robert Hogan <robert at webkit.org>  2011-01-31 12:09:52 PST ---
(In reply to comment #2)
> Created an attachment (id=80668)
 --> (https://bugs.webkit.org/attachment.cgi?id=80668&action=review) [details]
> Fix Qt Plugins compilation
> 
> Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk...

    // (ii) if we are running layout tests from DRT, paint() won't ever get called
    // so we need to call setNPWindowIfNeeded() if window geometry has changed
    if (!m_windowRect.intersects(frameView->frameRect())
        || (QWebPagePrivate::drtRun && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect)))
        setNPWindowIfNeeded();

I believe Qt layout tests are run headless, Gtk tests are not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.