[Webkit-unassigned] [Bug 46695] [Qt] Invalid pointer access & incomplete memcmp in setUpIterator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 11:44:41 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=46695





--- Comment #7 from chris reiss <christopher.reiss at nokia.com>  2011-01-31 11:44:40 PST ---
It seems to me that : 

   We can recycle the iterator if - 
   a) the strings are at the same location in memory, hence identical.   A comparison of (string== iterator.string) tests for this.
   b) the strings happen to be at different locations, but have the same content.
But in this case, we run the risk that 'string' points to freed memory (as Manuel pointed out).

   We could work around this by doing a string copy, but this may incur a worse performance hit than recreating the iterator.

Of course, a) is useless if there is some copying being done somewhere up the stack.   I'm testing for this now, that is, does the test ever pass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list