[Webkit-unassigned] [Bug 53296] Implicit form submission shouldn’t work when the default button is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53296


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80632|review?                     |review-
               Flag|                            |




--- Comment #7 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-01-31 09:00:52 PST ---
(From update of attachment 80632)
View in context: https://bugs.webkit.org/attachment.cgi?id=80632&action=review

> Source/WebCore/ChangeLog:5
> +        Implicit form submission shouldn’t work when the default button is disabled https://bugs.webkit.org/show_bug.cgi?id=53296

What's that odd character in shouldn't? Bug URL should go on a different line.

> Source/WebCore/ChangeLog:6
> +

There is usually a mention of a test here. Like so:

Test: fast/forms/implicit-submission.html

> Source/WebCore/html/HTMLFormElement.cpp:188
> +        if (formElement->getAttribute(typeAttr).lower() == "submit" || formElement->hasLocalName(buttonTag)) {

This is horrible. We shouldn't need to reach into attributes at this level. Why did you change this?

> LayoutTests/ChangeLog:5
> +        Implicit form submission shouldn’t work when the default button is disabled https://bugs.webkit.org/show_bug.cgi?id=53296

Same here.

> LayoutTests/fast/forms/implicit-submission.html:-19
> -    [ "Text input and text area and a disabled submit, text input focused", "!text,textarea,-submit", "y" ], // match IE, not FF.

Aha. This is interesting. So this change may break sites, expecting IE behavior?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.