[Webkit-unassigned] [Bug 25757] Cursor gets stuck when highlighting a textarea using Shift+Up

Mon Jan 31 00:09:32 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=25757

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leviw at chromium.org

--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-01-31 00:09:32 PST ---
(In reply to comment #6)
> ... because the start of the selection ends up with DOWNSTREAM affinity**.

If this is really the case, then this is the bug and needs to be fixed.

> I've verified that this is indeed the cause of the problem, by (in SelectionController::modifyExtendingBackward) changing
>   VisiblePosition pos(m_selection.extent(), m_selection.affinity())
> to
>   VisiblePosition pos(m_selection.extent(), UPSTREAM)
> but I don't think that that is necessarily the most "correct" solution.  What would be "correct" is that m_selection.affinity() somehow knows that last operation was to extend the selection backwards, and that the affinity should be UPSTREAM in this case... but that doesn't really make sense, since what does the affinity of a whole selection really mean?

The correct fix is to make m_selection.affinity() return UPSTREAM there.

> So perhaps the shortest path to a fix would be to change that to UPSTREAM.  And for the record, the change doesn't cause any layout tests to fail.

No. That may make sense for this specific case but it won't make sense for other cases.  I bet this is an issue with the trial SelectionController in SelectionController::modify.  http://trac.webkit.org/browser/trunk/Source/WebCore/editing/SelectionController.cpp#L699.  Levi will probably know how to fix this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.