[Webkit-unassigned] [Bug 52880] [GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52880





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-30 23:40:51 PST ---
(In reply to comment #5)
> (In reply to comment #2)
> > I grepped the entire source tree an only found implementations with no callers. Perhaps it makes more sense just to remove this method, as it appears to be dead code.
> 
> Sounds like a good idea to me.
> 
> About this patch.. is the MOD1 key guaranteed to be Alt?

GTK docs says:

"It depends on the modifier mapping of the X server which key is interpreted as this modifier, but normally it is the Alt key"

we are currently using it everywhere in gtk port, in MouseEventGtk.cpp we have a FIXME comment though:

// FIXME: Would be even better to figure out which modifier is Alt instead of always using GDK_MOD1_MASK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.