[Webkit-unassigned] [Bug 52846] InsertUnorderedList breaks up paragraphs when they contain non-editable elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52846


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80557|review?                     |review-
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-01-30 20:17:59 PST ---
(From update of attachment 80557)
View in context: https://bugs.webkit.org/attachment.cgi?id=80557&action=review

> Source/WebCore/editing/InsertListCommand.cpp:331
> -    VisiblePosition start = startOfParagraph(originalStart);
> -    VisiblePosition end = endOfParagraph(start);
> +    VisiblePosition start = startOfParagraph(originalStart, CanCrossEditingBoundary);
> +    VisiblePosition end = endOfParagraph(start, CanCrossEditingBoundary);

How do we ensure that the entire paragraph is editable if we allow start/end to cross editing boundary?  For example, if we had <div contenteditable="false">hello <span contenteditable="true">world</span></div>, and the caret is inside the span, we shouldn't be listifying "hello world".

Because of deep equivalent positions, I don't think we're ready to fix this kind of bugs properly yet.  Also, please don't just fix InsertUnorderedList.  At least InsertOrderedList must also be fixed.  And I'm sure the same bug exists for IndentOutdentCommand and FormatBlockCommand.  If you're interested in working on InsertListCommand, please fix crash/hang bugs we have as they have a higher priority.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.