[Webkit-unassigned] [Bug 52846] InsertUnorderedList breaks up paragraphs when they contain non-editable elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52846





--- Comment #4 from Benjamin (Ben) Kalman <kalman at chromium.org>  2011-01-30 17:02:36 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=80557&action=review

> LayoutTests/editing/execCommand/insert-list-inside-editable-paragraph-containing-noneditable-elements.html:3
> +<div id="test2" contenteditable="true"><p id="test2-p">This is another editable paragraph that contains a <span contenteditable="false">non-editable</span> span.</p></div>

Why the extra ps, rather than just using the containing div?

Anyway, rather than repeating the same test case, it would be nice to test some different cases, such as
 - non-editable span at the start of the paragraph
 - non-editable span at the end of the paragraph
 - non-editable span in the middle somewhere (as you have)
 - multiple lines (with non-editable spans), no selection
 - multiple lines (with non-editable spans), with the selection across multiple lines (i.e. use getSelection().modify("extend", "forward", "line") or something)

> LayoutTests/editing/execCommand/insert-list-inside-editable-paragraph-containing-noneditable-elements.html:15
> +Markup.dump("test1", "The whole paragraph - non-editable part included - must become a list item");

I'd pull this common logic into a function.
Also, if there is a way to just print "PASS ..." or "FAIL ..." then that would be more concise than using Markup and easier to understand regressions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.