[Webkit-unassigned] [Bug 53090] [Qt][WK2] Add a way to use shared process model in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53090





--- Comment #4 from Balazs Kelemen <kbalazs at webkit.org>  2011-01-30 14:53:20 PST ---
> I do not understand. You are saying "Currently every new window creates a new QWKContext", which is actually what your patch does, not what I see from the previous code.

Because it is so confusing :)
Default value of the QWKContext* argument of BrowserWindow's ctor is 0.
Currently every instantiation use the default value. The pointer is then 
passed to BrowserView's ctor that actually creates a new context if got 0
argument (and leaks it). So we are creating a new QWKContext on every 
BrowserWindow  instantiation. With the patch the context of the first window
is reused in the newWindow method by default so this context is shared between
all windows.

> 
> I think the patch is also incomplete, you do not include creating a window through newPageFunction().

The page (and window) that is created by this function must use the same context as it's creator.
This is called as a PageClient virtual method from inside the lib according to a window.open() js call
or something similar so the new page must be scriptable from the creator page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.