[Webkit-unassigned] [Bug 53400] New: [Qt][WK2]REGRESSION (r76991): Fix build errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 30 10:59:15 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53400

           Summary: [Qt][WK2]REGRESSION (r76991): Fix build errors
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: Qt, QtTriaged
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: andersca at apple.com, sam at webkit.org,
                    kbalazs at webkit.org, laszlo.1.gombos at nokia.com,
                    abecsi at webkit.org
            Blocks: 50174


31    #ifdef __cplusplus 
32    #define new ("if you use new/delete make sure to include config.h at the top of the file"())  
33    #define delete ("if you use new/delete make sure to include config.h at the top of the file"())

This change caused build error in moc_qwkhistory.cpp and moc_qwkpage.cpp .
These files are generated from qwkhistory.h and qwkpage.h by Qt's moc and
they only inlcude its own header file.

To fix this build break I added including config.h to these headers:
http://trac.webkit.org/changeset/77088

I know we shouldn't include config.h in headers, but I don't know if it 
is possible to make moc add including config.h to moc_[...].cpp files.

I leave this bug open to find a correct solution for this build break.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list