[Webkit-unassigned] [Bug 50747] [GTK] drop soup cache stuff, use versions from libsoup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50747





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2011-01-29 18:16:44 PST ---
(In reply to comment #9)
> Created an attachment (id=80574)
 --> (https://bugs.webkit.org/attachment.cgi?id=80574&action=review) [details]
> updated again to (almost) pass check-webkit-style
> 
> The NULL-vs-0 warning from check-webkit-style is wrong. Apparently we could suppress it by squishing the entire g_object_set() call onto a single line, but I didn't do that because (a) it would be ugly, and (b) that code was already in ResourceHandleSoup.cpp anyway, I just moved it within the file.

It can also lead to crashes on 64-bit systems, so it's actively dangerous to use 0!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.