[Webkit-unassigned] [Bug 45423] [Gtk] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45423





--- Comment #40 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-01-29 14:51:39 PST ---
(From update of attachment 80561)
View in context: https://bugs.webkit.org/attachment.cgi?id=80561&action=review

> Source/WebCore/platform/graphics/gtk/TileGtk.cpp:75
> +static cairo_surface_t* checkeredSurface()
> +{
> +    static cairo_surface_t* surface = 0;
> +    if (surface)
> +        return surface;
> +
> +    surface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, checkerSize, checkerSize);
> +    RefPtr<cairo_t> cr = adoptRef(cairo_create(surface));
> + 
> +    for (unsigned y = 0; y < checkerSize; y += checkerSize / 2) {
> +        bool alternate = y % checkerSize;
> +        for (unsigned x = 0; x < checkerSize; x += checkerSize / 2) {
> +            if (alternate)
> +                setSourceRGBAFromColor(cr.get(), checkerColor1);
> +            else
> +                setSourceRGBAFromColor(cr.get(), checkerColor2);
> +            cairo_rectangle(cr.get(), x, y, checkerSize / 2, checkerSize / 2); 
> +            cairo_fill(cr.get());
> +            alternate = !alternate;
> +        }
> +    }
> +
> +    return surface;
> +}

I believe that we should let the embedding app paint the checker boards. Especially because sometimes you want the checkerboards area to be bigger than the contents size (think on rotation, look how it is done on the iPad - try using google.com).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.