[Webkit-unassigned] [Bug 25624] REGRESSION(r33963-r33980): Function.toString preserves quote style, but it shouldn't

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 15:29:36 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=25624


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com




--- Comment #10 from Geoffrey Garen <ggaren at apple.com>  2011-01-28 15:29:35 PST ---
Chris, I'm glad you made the effort to fix this, and I hate to say it, but do we really want to make this change?

It looks like the website this was reported against has since been fixed, and we've had no reports of this bug at other websites. I'd prefer not to go through contortions in JavaScriptCore to maintain compatibility with a poorly coded website that doesn't exist anymore.

In general, we made a choice a few years ago not to decompile or specially contort JavaScript in Function.prototype.toString. We just return the original string provided in source code. A bug or two has cropped up here and there from poorly coded websites, but we haven't seen one that justified going back on our strategy yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list