[Webkit-unassigned] [Bug 53316] NULL pointer crash when using :empty and :first-line pseudoclass selectors together

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 12:40:59 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53316





--- Comment #1 from Thomas Sepez <tsepez at chromium.org>  2011-01-28 12:41:00 PST ---
In RenderBlock::lineHeight():

   if (firstLine && document()->usesFirstLineRules()) {
        RenderStyle* s = style(firstLine);
        if (s != style())
            return s->computedLineHeight();

we're getting a NULL back from style(firstLine).

This is called once successfully, but the second call returns 0, because eventually RenderObject::getUncachedPseudoStyle() is taking a "return 0" path.   While this code should protect itself against this case via something like 

           if (s && s != style())

it's not clear that this is sufficient; would like to know why it's not finding any style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list