[Webkit-unassigned] [Bug 53263] contentEditable formatBlock crashes on divs with contenteditable="false"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53263


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80371|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2011-01-27 16:16:36 PST ---
(From update of attachment 80371)
View in context: https://bugs.webkit.org/attachment.cgi?id=80371&action=review

>> Source/WebCore/editing/FormatBlockCommand.cpp:72
>> +        return;
> 
> Why don’t other commands need this kind of check? Is this really specific to FormatBlock?

I figured out the answer to my own question. The simple editing commands all have code in them that checks and does nothing if the nodes involved are not editable. And the complex commands are built out of the simple commands. So in most cases, no checking is needed.

There may be some advantage to doing some higher level checking so we don’t end up with undoable commands on the undo chain that work hard to do nothing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.