[Webkit-unassigned] [Bug 52868] [chromium] Fix redundant video frame paint on CSS LayerChromium for <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52868


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80286|review?                     |review+
               Flag|                            |




--- Comment #7 from James Robinson <jamesr at chromium.org>  2011-01-27 13:56:17 PST ---
(From update of attachment 80286)
View in context: https://bugs.webkit.org/attachment.cgi?id=80286&action=review

Seems good.  Could you please confirm that this code change is hit by existing tests (at least some of the webgl ones) and that they still work with this patch applied?

> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:-486
> -
> -#if USE(ACCELERATED_COMPOSITING)
> -    Frame* frame = static_cast<HTMLMediaElement*>(
> -        client->m_mediaPlayer->mediaPlayerClient())->document()->frame();
> -
> -    // This does not actually check whether the hardware can support accelerated
> -    // compositing, but only if the flag is set. However, this is checked lazily
> -    // in WebViewImpl::setIsAcceleratedCompositingActive() and will fail there
> -    // if necessary.
> -    client->m_supportsAcceleratedCompositing =
> -        frame->contentRenderer()->compositor()->hasAcceleratedCompositing();
> -#endif

I don't understand this code move - is this part of the same patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.