[Webkit-unassigned] [Bug 49649] [GTK] On-demand event-listeners for DOM event signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49649





--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-01-27 10:58:27 PST ---
(From update of attachment 80347)
View in context: https://bugs.webkit.org/attachment.cgi?id=80347&action=review

This seems good to me, but I think we still need to decide what approach we're taking to the API. I'm in favor of having both signals and *_add_event_listener. The signal names will be GLib-style and the *_add_event_listeners taking DOM-style event names. Signals could be added when GLib has proper support for detecting when handlers are attached.

> Source/WebCore/bindings/gobject/GObjectEventListener.cpp:74
> +    (*(void (*)(GObject*, WebKitDOMEvent*, void*))m_handler)(m_object, gobjectEvent, m_userData);

If possible this should be a static_cast or reinterpret_cast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.