[Webkit-unassigned] [Bug 53244] A user gesture bug which can bypass popup blocker using iframe SRC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53244





--- Comment #4 from Johnny(Jianning) Ding <jnd at chromium.org>  2011-01-27 10:41:56 PST ---
(In reply to comment #3)
> Can we just remove that parameter entirely?  Now that we keep the gesture state in a static variable, we shouldn't need to pass it around explicitly.

Currently when you type javascript URL in address bar and press Enter, the WebKit port will directly call ScriptController::executeScript(url, true, ...).

So you mean we can change all those calls to the following way,
{
UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
ScriptController::executeScript(url, ...);
}

I think we can do that, but I need to re-check all related code and it will change lots of code. I think we may need to file another bug for removing "forceUserGesture" parameter.

Does it make sense?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.