[Webkit-unassigned] [Bug 51364] Web Inspector: Remote Web Inspector - Cross Platform InspectorServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51364





--- Comment #53 from Joseph Pecoraro <joepeck at webkit.org>  2011-01-27 10:31:19 PST ---
(In reply to comment #50)
> (From update of attachment 80254 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80254&action=review
> 
> > Source/WebCore/inspector/InspectorServer.cpp:1
> > +/*
> 
> My biggest concern is that this class lives in the WebCore. In Chromium, we can't do page discovery from within the WebCore and we also can't open listen socket from there.

The main advantage of having InspectorServer be in WebCore was to share some of the
code for setting up connections and disallowing remote inspection. For example, the
upgrade request paths "/devtools/page/<num>", listing page "/", disallow for private
browsing, existing inspectors, etc. But that isn't too much code, and maybe I could
come up with a way to share it. Suggestions are appreciated.

> What is it going to be like in WebKit2? I was thinking that we implement it a bit differently:
> - WebCore (or WebKit/cf) contains code that can be reused by the platforms in order to support HTTP/WebSocket server infrastructure
> - WebKit layer instantiates it and pipes messages to the corresponding InspectorController instance.

Unfortunately I don't know much about the cross platform setups (Chromium and WebKit2).
It sounds like to ensure there really is only 1 InspectorServer it should be in the WebKit layer.
As for WebKit2, I'd be interested how other singletons, like the PageCache work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.