[Webkit-unassigned] [Bug 51364] Web Inspector: Remote Web Inspector - Cross Platform InspectorServer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 08:39:16 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51364


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ukai at chromium.org,
                   |                            |yuzo at google.com




--- Comment #51 from Alexey Proskuryakov <ap at webkit.org>  2011-01-27 08:39:14 PST ---
> Would you be happier with this if the files were renamed to be less generic, and maybe all 
> kept inside of WebCore/websockets?

Probably. If it's only for WebSockets-76, we shouldn't pretend it's HTTP. But I'm not sure about future versions - I've heard that those are fully HTTP compatible, so having a full cross-platform implementation could be less than great.

> In this patch the class WebSocketHandshakeRequest became a subclass of RefCounted HTTPRequest,
> and so I found it easier to pass a pointer to the request (refCountedRequest.get()). Is there a convenient
> way I could stick with the old prototype?

It's not a very common idiom in WebCore, but I like to pass by reference when arguments can't be null. You can just do *refCountedRequest.get().

> This is unchanged from the existing patch. But yes, it's worth a new bug.
> <http://webkit.org/b/53224> Web Socket Console Messages Are Not Localized

I don't know if other console messages are localized. 

> Currently it looks like `run-new-webkit-websocketserver` uses pywebsocket. What does
> that mean for when we update our WebSocket client implementation to a new draft or
> edition? Do we also have to update pywebsocket? Wait for a new version? Find a new
> server library to test against? Or would it be easier to maintain our own server, as above?

Although pywebsocket is a separate project, it's being developed together with WebCore WebSocket implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list