[Webkit-unassigned] [Bug 53241] ResourceLoadScheduler::scheduleSubresourceLoad() should use ResourceRequest priority

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53241





--- Comment #1 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-01-27 08:38:12 PST ---
Created an attachment (id=80334)
 --> (https://bugs.webkit.org/attachment.cgi?id=80334&action=review)
Experimental patch

NOTE: When this patch is applied to a Snow Leopard system (which doesn't use HTTP pipelining), a single test fails:

    LayoutTests/http/tests/xmlhttprequest/logout.html

Running the layout test in Safari 5.0.3 (with a recent WebKit but without the patch applied), these URLs are loaded and the test PASSES:

127.0.0.1 - - [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/logout.html HTTP/1.1" 200 2083
127.0.0.1 - - [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/resources/logout/resource.php?login HTTP/1.1" 401 23
127.0.0.1 - user [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/resources/logout/resource.php?login HTTP/1.1" 200 27
127.0.0.1 - user [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 200 27
127.0.0.1 - logout [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 401 23
127.0.0.1 - logout [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 401 23
127.0.0.1 - user [24/Jan/2011:15:45:46 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 200 27
127.0.0.1 - - [24/Jan/2011:15:45:46 -0800] "GET /favicon.ico HTTP/1.1" 200 1150

After applying the patch and running Safari 5.0.3 with the new WebKit, these URLs are loaded and the test FAILS:

127.0.0.1 - - [24/Jan/2011:15:45:50 -0800] "GET /xmlhttprequest/logout.html HTTP/1.1" 200 2083
127.0.0.1 - - [24/Jan/2011:15:45:50 -0800] "GET /xmlhttprequest/resources/logout/resource.php?login HTTP/1.1" 401 23
127.0.0.1 - user [24/Jan/2011:15:45:51 -0800] "GET /xmlhttprequest/resources/logout/resource.php?login HTTP/1.1" 200 27
127.0.0.1 - user [24/Jan/2011:15:45:51 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 200 27
127.0.0.1 - user [24/Jan/2011:15:45:51 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 200 27
127.0.0.1 - user [24/Jan/2011:15:45:51 -0800] "GET /xmlhttprequest/resources/logout/resource.php?isAuthenticated HTTP/1.1" 200 27
127.0.0.1 - - [24/Jan/2011:15:45:51 -0800] "GET /favicon.ico HTTP/1.1" 200 1150

There seems to be a dependency on the separate priority passed through ResourceLoadScheduler::scheduleSubresourceLoad().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.