[Webkit-unassigned] [Bug 53189] SVG animation doesn't support calcMode discrete for number and color values.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53189


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80236|review?                     |review+
               Flag|                            |




--- Comment #3 from Nikolas Zimmermann <zimmermann at kde.org>  2011-01-27 02:24:19 PST ---
(From update of attachment 80236)
View in context: https://bugs.webkit.org/attachment.cgi?id=80236&action=review

r=me.

> Source/WebCore/svg/SVGAnimateElement.cpp:103
> +    bool isInFirstHalfOfAnimation = percentage < 0.5;

0.5f?

> LayoutTests/svg/animations/script-tests/animate-color-calcMode-discrete.js:38
> +        ["animation", 0.001,    "rect", sample1],

Formatting, you should lign up the "rect" lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.