[Webkit-unassigned] [Bug 52296] [Qt]Add local storage settings to QtTestBrowser option menu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 02:18:59 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52296


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79846|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from Andreas Kling <kling at webkit.org>  2011-01-27 02:19:00 PST ---
(From update of attachment 79846)
View in context: https://bugs.webkit.org/attachment.cgi?id=79846&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:919
> +        QDialog* dialog = new QDialog(this);

This whole section could be replaced with a call to QInputDialog::getInt(), let's do that instead.

> Tools/QtTestBrowser/main.cpp:167
> +        windowOptions.useLocalStorage = true;        

Unnecessary whitespace.

> Tools/QtTestBrowser/main.cpp:178
> +        windowOptions.offlineStorageDefaultQuotaSize = maxSize;        

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list