[Webkit-unassigned] [Bug 52873] Chromium DRT should provide command-line option for specifying timeout to ease debugging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52873





--- Comment #12 from Xianzhu Wang <wangxianzhu at google.com>  2011-01-26 17:25:08 PST ---
(In reply to comment #8)

Thanks Tony for review.

> (From update of attachment 80169 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80169&action=review
> 
> At some point, we should see if we can get Chromium DRT to do the same as Mac DRT and call notifyDone on timeout.
> 

Non-Chromium DRT also has their problems:
1. Sometimes NRWT must kill the DRT process if it wants a timeout shorter than 30s. For Chromium DRT, the script can specify timeout for each test in test-shell mode.

2. If the DRT process is busy in a loop, it can't quit by itself and can only be killed.

> > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:191
> > +            // 0x20000000ms is big enough for the purpose to avoid timeout in debugging.
> > +            shell.setLayoutTestTimeout(0x20000000);
> 
> Why did you decide against INT_MAX from climits?

I'm afraid if INT_MAX as a timeout was added to some value it would overflow, for example, some port might need 1 more second for timeout.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.