[Webkit-unassigned] [Bug 53206] SPI to temporarily disable updating the size of the drawing area during WKView frame resizes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53206


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80270|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-01-26 17:22:09 PST ---
(From update of attachment 80270)
View in context: https://bugs.webkit.org/attachment.cgi?id=80270&action=review

I am saying review+ here, but I don’t think this merits adding WKViewPrivate.

> Source/WebKit2/ChangeLog:5
> +        SPI to temporarily disable size updates to the page drawing area in WKView.

This is no more SPI than any other aspect of WebKit2. I suggest not using the term SPI.

>> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:26
>> + at interface WKView (Private)
> 
> Extra space before ( in function call  [whitespace/parens] [4]

This is a bug in the style queue.

> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:34
> +// Stops updating the size of the page as the WKView frame size updates.
> +// This should always be followed by enableFrameSizeUpdates. Calls can be nested.
> +- (void)disableFrameSizeUpdates;
> +// Immediately updates the size of the page to match WKView's frame size
> +// and allows subsequent updates as the frame size is set. Calls can be nested.
> +- (void)enableFrameSizeUpdates;
> +- (BOOL)frameSizeUpdatesDisabled;

I don’t think these need to be in a separate private header. Why wouldn’t we make these public for any client of WKView?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.