[Webkit-unassigned] [Bug 53150] initial support for close() in indexeddb backend
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 26 17:17:20 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=53150
Jeremy Orlow <jorlow at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80267|review? |review-
Flag| |
--- Comment #4 from Jeremy Orlow <jorlow at chromium.org> 2011-01-26 17:17:21 PST ---
(From update of attachment 80267)
View in context: https://bugs.webkit.org/attachment.cgi?id=80267&action=review
> LayoutTests/storage/indexeddb/transaction-after-close.html:66
> + evalAndLog("objectStore.put('a', 'b')");
Whenever you do something, you should at least set an onerror handler to be unexpectedErrorCallback
> LayoutTests/storage/indexeddb/transaction-after-close.html:87
> + currentTransaction.onabort = done;
It's probably worth doing something on this transaction and verifying its onsuccess fires
> Source/WebCore/storage/IDBDatabase.cpp:48
> + : m_backend(backend), m_noNewTransactions(false)
, and such on newline
> Source/WebCore/storage/IDBDatabase.cpp:-129
> - m_backend->close();
The setVersion logic is going to need to run in the backend, so you still need to do this.
> Source/WebCore/storage/IDBDatabase.cpp:133
> + m_noNewTransactions = true;
Right now, we try to do as much of the logic as is possible in the backend. I think we should probably move this there especially since we need to plumb close anyway.
> Source/WebCore/storage/IDBDatabase.h:80
> + bool m_noNewTransactions;
this should be on the backend object
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list