[Webkit-unassigned] [Bug 51364] Web Inspector: Remote Web Inspector - Cross Platform InspectorServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51364





--- Comment #44 from Joseph Pecoraro <joepeck at webkit.org>  2011-01-26 17:15:20 PST ---
(From update of attachment 80249)
View in context: https://bugs.webkit.org/attachment.cgi?id=80249&action=review

>> Source/WebCore/ChangeLog:13
>> +        didReceiveConnection callback with a generic SocketStreamHandle.
> 
> I'm not sure if "didReceiveConnection" parses. Maybe "establish"?

I use "establish" in later patches on to mean a connection that has had some setup. How about, "didAcceptConnection"?

>> Source/WebCore/platform/network/ServerSocketHandleBase.cpp:49
>> +        return;
> 
> We only do this when fixing super elusive bugs by adding semi-arbitrary null checks. If m_port can't be null, just assert, and don't make runtime checks.

Sounds good.

>> Source/WebCore/platform/network/ServerSocketHandleClient.h:45
>> +} // namespace WebCore
> 
> I'm not a fan of such comments - if you really need to check what this brace at the end of the file is for, you'll double-click it for IDE to balance, and if you're not, why is this boilerplate asking for attention?

This was just boilerplate I have because all other files have it. I'm fine with removing this and some endif comments.

>> Source/WebCore/platform/network/cf/ServerSocketHandleCFNet.cpp:58
>> +    m_serverFileDescriptor = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP);
> 
> We don't have CF level APIs to create listening sockets? This whole function feels alien, with perror and such.

Correct, I am not aware of any CF level APIs for listening sockets =(.

>> Source/WebCore/platform/network/cf/ServerSocketHandleCFNet.cpp:70

> 
> Should there be any limit on which interfaces to bind to? Even when running regression tests, we only listen on loopback, because opening up on all interfaces isn't prudent security wise.

Hmm, it was mentioned before that maybe we should only allow localhost and "for cross machine debugging you can use ssh port forwarding etc." I'm just not familiar with how this works. I don't want to leave this as is if there is so much concern. I'll need to investigate this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.