[Webkit-unassigned] [Bug 53183] MathExtras.h missing additional "using std::<cmathfunction>" statements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 12:57:28 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53183


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80214|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Darin Adler <darin at apple.com>  2011-01-26 12:57:28 PST ---
(From update of attachment 80214)
View in context: https://bugs.webkit.org/attachment.cgi?id=80214&action=review

review- because this is breaking the build on every platform!

>> Source/JavaScriptCore/wtf/MathExtras.h:215
>> +using std::acos;
> 
> Use 'using namespace std;' instead of 'using std::acos;'.  [build/using_std] [4]

The stylebot should enforce that rule in .cpp files, but not in .h files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list