[Webkit-unassigned] [Bug 53183] MathExtras.h missing additional "using std::<cmathfunction>" statements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 26 12:09:28 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=53183
--- Comment #4 from Nick Landry <nlandry at rim.com> 2011-01-26 12:09:28 PST ---
Should be "I decided against"
(In reply to comment #3)
> I decided again having "using namespace std;" in a header file since I figured it could have unintended consequences for someone who includes it but may not want all of std imported.
>
> (In reply to comment #2)
> > Attachment 80214 [details] [details] did not pass style-queue:
> >
> > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> >
> > Source/JavaScriptCore/wtf/MathExtras.h:215: Use 'using namespace std;' instead of 'using std::acos;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:216: Use 'using namespace std;' instead of 'using std::asin;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:217: Use 'using namespace std;' instead of 'using std::atan2;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:218: Use 'using namespace std;' instead of 'using std::atan2f;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:219: Use 'using namespace std;' instead of 'using std::ceil;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:220: Use 'using namespace std;' instead of 'using std::ceilf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:221: Use 'using namespace std;' instead of 'using std::cos;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:222: Use 'using namespace std;' instead of 'using std::cosf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:223: Use 'using namespace std;' instead of 'using std::fabs;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:224: Use 'using namespace std;' instead of 'using std::fabsf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:225: Use 'using namespace std;' instead of 'using std::floorf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:226: Use 'using namespace std;' instead of 'using std::fmod;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:227: Use 'using namespace std;' instead of 'using std::hypot;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:228: Use 'using namespace std;' instead of 'using std::sin;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:229: Use 'using namespace std;' instead of 'using std::sinf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:230: Use 'using namespace std;' instead of 'using std::sqrt;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:231: Use 'using namespace std;' instead of 'using std::sqrtf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:232: Use 'using namespace std;' instead of 'using std::tan;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:233: Use 'using namespace std;' instead of 'using std::tanf;'. [build/using_std] [4]
> > Total errors found: 19 in 2 files
> >
> >
> > If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3)
> I decided again having "using namespace std;" in a header file since I figured it could have unintended consequences for someone who includes it but may not want all of std imported.
>
> (In reply to comment #2)
> > Attachment 80214 [details] [details] did not pass style-queue:
> >
> > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> >
> > Source/JavaScriptCore/wtf/MathExtras.h:215: Use 'using namespace std;' instead of 'using std::acos;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:216: Use 'using namespace std;' instead of 'using std::asin;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:217: Use 'using namespace std;' instead of 'using std::atan2;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:218: Use 'using namespace std;' instead of 'using std::atan2f;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:219: Use 'using namespace std;' instead of 'using std::ceil;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:220: Use 'using namespace std;' instead of 'using std::ceilf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:221: Use 'using namespace std;' instead of 'using std::cos;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:222: Use 'using namespace std;' instead of 'using std::cosf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:223: Use 'using namespace std;' instead of 'using std::fabs;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:224: Use 'using namespace std;' instead of 'using std::fabsf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:225: Use 'using namespace std;' instead of 'using std::floorf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:226: Use 'using namespace std;' instead of 'using std::fmod;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:227: Use 'using namespace std;' instead of 'using std::hypot;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:228: Use 'using namespace std;' instead of 'using std::sin;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:229: Use 'using namespace std;' instead of 'using std::sinf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:230: Use 'using namespace std;' instead of 'using std::sqrt;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:231: Use 'using namespace std;' instead of 'using std::sqrtf;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:232: Use 'using namespace std;' instead of 'using std::tan;'. [build/using_std] [4]
> > Source/JavaScriptCore/wtf/MathExtras.h:233: Use 'using namespace std;' instead of 'using std::tanf;'. [build/using_std] [4]
> > Total errors found: 19 in 2 files
> >
> >
> > If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list