[Webkit-unassigned] [Bug 52876] Chromium DRT should clear page between tests like what Mac DRT does

Tue Jan 25 17:46:00 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52876

Xianzhu Wang <phnixwxz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org,
                   |                            |phnixwxz at gmail.com

--- Comment #11 from Xianzhu Wang <phnixwxz at gmail.com>  2011-01-25 17:45:59 PST ---
(In reply to comment #10)
> (From update of attachment 80052 [details])
> It looks like the mac port actual loads the HTML string <html></html> with the URL about:blank.  Does it matter?

@Alexey, what's the difference between 
[mainFrame loadHTMLString:@"<html></html>" baseURL:[NSURL URLWithString:@"about:blank"]]
and
[mainFrame loadRequest:[NSURLRequest requestWithURL:url]] (where the url is about:blank) ?

> The mac port also immediately calls stopLoading().  Do we need to do that too?
>

Yes, I think so.

> The ChangeLog for Mac DRT says this is to delay onload handlers, so it doesn't seem like Mac DRT has the same problem with GL contexts.  I suspect there is a real chromium/v8 bug here and this is going to make it harder to fix that bug.  However, being more consistent with the Mac DRT is a good thing, so I think this change is worthwhile.
> 

The purpose of this CL has changed. Now the intent is only to keep consistent with Mac DRT. It won't help GL contexts without calling GC.

It shouldn't be a v8 bug. The automatic GC triggering mechanism is unable to detect resources (e.g. GL contexts) that is not controlled by it. We must trigger it from the outside of the script engine. I've filed a bug http://code.google.com/p/chromium/issues/detail?id=70736 about that issue in Chromium and will create a CL for it.

About clearing between tests, I still think we should do some experiments (which might need the test bots and the --clear-between-tests option helps) to prove if loading 'about:blank' and GC between tests could reduce flakyness. Without GC, some resources allocated in the current page will be destructed when testing later pages which might cause uncertainty.

> In the ChangeLog, please explain why this is being added to the Chromium DRT.
>

OK.

> r- mainly for ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.